Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate jlink plugin #797

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Validate jlink plugin #797

merged 2 commits into from
Jan 31, 2025

Conversation

vpa1977
Copy link
Contributor

@vpa1977 vpa1977 commented Jan 29, 2025

This PR adds JLink plugin smoke test to rockcraft.

The PR is draft until craft-parts release.

Commit 42b68dd should be removed from the final PR.

  • Have you signed the CLA?

@vpa1977 vpa1977 force-pushed the validate-jlink-plugin branch 2 times, most recently from 9d70f39 to d0a7a43 Compare January 29, 2025 03:58
@vpa1977 vpa1977 mentioned this pull request Jan 29, 2025
Merged
2 tasks
@vpa1977
Copy link
Contributor Author

vpa1977 commented Jan 29, 2025

Note: spread failures:

2025-01-29 05:13:36 Failed tasks: 2
    - google:ubuntu-22.04-64:docs/how-to/code/build-docs
    - google:ubuntu-22.04-64:tests/spread/rockcraft/fetch-service
2025-01-29 05:13:36 Failed task restore: 1
    - google:ubuntu-22.04-64:tests/spread/rockcraft/fetch-service
error: unsuccessful run

@vpa1977 vpa1977 requested a review from tigarmo January 29, 2025 23:52
@vpa1977
test: add test for jlink plugin
886930b 
A smoke test for jlink plugin.
It builds Java hello world rocks for bare and Ubuntu 24.04 bases.
The test depends on Maven plugin to work properly.
@vpa1977 vpa1977 force-pushed the validate-jlink-plugin branch from 9caa5cf to 886930b Compare January 31, 2025 09:12
tigarmo
tigarmo approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks!

tests/spread/rockcraft/plugin-jlink/parts.yaml Show resolved Hide resolved
@tigarmo tigarmo marked this pull request as ready for review January 31, 2025 12:38
@tigarmo tigarmo requested a review from a team January 31, 2025 12:38
@tigarmo tigarmo added the squash label Jan 31, 2025
mr-cal
mr-cal approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vpa1977

@tigarmo tigarmo merged commit 3142899 into canonical:main Jan 31, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-cal mr-cal mr-cal approved these changes

@tigarmo tigarmo tigarmo approved these changes

Assignees
No one assigned
Labels
squash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vpa1977 @tigarmo @mr-cal